[PATCH 5/6] ui-atom: fix resource leak: free allocation from cgit_pageurl
Christian Hesse
list at eworm.de
Sat Oct 10 16:56:27 CEST 2015
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13945
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-atom.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui-atom.c b/ui-atom.c
index fab4b0f..e186299 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -53,14 +53,17 @@ static void add_entry(struct commit *commit, const char *host)
cgit_print_date(info->author_date, FMT_ATOMDATE, 0);
html("</published>\n");
if (host) {
+ char *pageurl;
html("<link rel='alternate' type='text/html' href='");
html(cgit_httpscheme());
html_attr(host);
- html_attr(cgit_pageurl(ctx.repo->url, "commit", NULL));
+ pageurl = cgit_pageurl(ctx.repo->url, "commit", NULL);
+ html_attr(pageurl);
if (ctx.cfg.virtual_root)
delim = '?';
htmlf("%cid=%s", delim, hex);
html("'/>\n");
+ free(pageurl);
}
htmlf("<id>%s</id>\n", hex);
html("<content type='text'>\n");
--
2.6.1
More information about the CGit
mailing list