[PATCH 1/4] shared: remove return value from cgit_free_commitinfo()

John Keeping john at keeping.me.uk
Sat Aug 13 13:04:29 CEST 2016


This return value is never used and the function always returns NULL.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
 cgit.h   | 2 +-
 shared.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/cgit.h b/cgit.h
index 325432b..ec73dd3 100644
--- a/cgit.h
+++ b/cgit.h
@@ -343,7 +343,7 @@ extern void cgit_free_reflist_inner(struct reflist *list);
 extern int cgit_refs_cb(const char *refname, const struct object_id *oid,
 			int flags, void *cb_data);
 
-extern void *cgit_free_commitinfo(struct commitinfo *info);
+extern void cgit_free_commitinfo(struct commitinfo *info);
 
 void cgit_diff_tree_cb(struct diff_queue_struct *q,
 		       struct diff_options *options, void *data);
diff --git a/shared.c b/shared.c
index a63633b..432ce61 100644
--- a/shared.c
+++ b/shared.c
@@ -95,7 +95,7 @@ struct cgit_repo *cgit_get_repoinfo(const char *url)
 	return NULL;
 }
 
-void *cgit_free_commitinfo(struct commitinfo *info)
+void cgit_free_commitinfo(struct commitinfo *info)
 {
 	free(info->author);
 	free(info->author_email);
@@ -105,7 +105,6 @@ void *cgit_free_commitinfo(struct commitinfo *info)
 	free(info->msg);
 	free(info->msg_encoding);
 	free(info);
-	return NULL;
 }
 
 char *trim_end(const char *str, char c)
-- 
2.9.2.639.g855ae9f



More information about the CGit mailing list