[PATCH 0/8] Show times in the originator's timezone
john at keeping.me.uk
Mon Feb 8 15:08:44 CET 2016
On Mon, Feb 08, 2016 at 02:38:57PM +0100, Jason A. Donenfeld wrote:
> This series is faulty. See git.zx2c4.com
> It shows (GMT) when those times are not GMT.
You're right, it seems that the problem is that we end up using
strftime(3) with %Z for the timezone, but that function doesn't take an
explicit timezone so it just ends up using the system one.
I think we should just switch to using DATE_SHORT and DATE_ISO8601 from
Git's date_mode_type enum; I didn't do so originally because the format
doesn't quite match what we have used traditionally, but now that I look
again it's not that different so I reckon we should just switch (it was
a bigger problem before Git learned that "local" is orthogonal to the
We may still need a custom strftime(3) string for FMT_ATOMDATE, but
DATE_ISO8601_STRICT may be enough; it depends whether atom dates have to
be in +00:00 or not.
More information about the CGit