[PATCH 1/2] ui-shared: add homepage to tabs
John Keeping
john at keeping.me.uk
Mon Feb 22 18:03:48 CET 2016
On Mon, Feb 22, 2016 at 04:42:12PM +0100, Jason A. Donenfeld wrote:
> Seems like a very useful feature. I'd like some feedback on ➦ though.
>
> It'd be nice to have this:
> http://fortawesome.github.io/Font-Awesome/icon/external-link/
> or this:
> http://www.fileformat.info/info/unicode/char/1f517/index.htm
>
> But the former is overhead I won't accept and the latter isn't
> available in all browsers.
>
> Thoughts?
I'm not convinced by the arrow, I wonder if we'd be better off inlining
Wikipedia's external link image [1] as base64; it's quite small and is
licensed as GPLv2.
It might be nice to move this into CSS with an "external_link" class and
use :after to apply the image which will make per-site customization
easier.
[1] https://commons.wikimedia.org/wiki/File:Icon_External_Link.png
More information about the CGit
mailing list