[PATCH v2 2/2] ui-repolist: return HTTP 404 if no repositories found

Peter Colberg peter at colberg.org
Wed Jan 13 23:25:05 CET 2016


On Wed, Jan 13, 2016 at 05:21:21PM +0100, Jason A. Donenfeld wrote:
> Thanks Peter. I merged this with some changes:
>
> http://git.zx2c4.com/cgit/commit/?id=9abe4a26a92b91170cb9c5dab830b40fb1e0327f

Thanks for merging, Jason.

> Note that in C you need to specify (void) in the argument list if it
> doesn't take any arguments. Otherwise it takes a variable number of
> arguments.

I knew about (void) in C and still made this mistake.

The following commits add compiler warning flags to prevent this mistake
from happening ever again and fix various declarations without (void).

Regards,
Peter

Peter Colberg (2):
  Compile with -Wstrict-prototypes -Wmissing-prototypes
  Fix missing prototype declarations

 cgit.mk       |  5 +++++
 ui-diff.h     |  2 +-
 ui-refs.h     |  2 +-
 ui-repolist.h |  4 ++--
 ui-shared.h   | 12 ++++++------
 ui-ssdiff.h   |  8 ++++----
 ui-summary.h  |  2 +-
 7 files changed, 20 insertions(+), 15 deletions(-)

-- 
2.7.0.rc3



More information about the CGit mailing list