[PATCH] ui-repolist: Tweak max-repo-count handling

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Thu Jun 9 17:32:58 CEST 2016

On 18 June 2015 at 15:48, Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
> On 18 June 2015 at 15:02, John Keeping <john at keeping.me.uk> wrote:
>> On Thu, Jun 18, 2015 at 02:18:32PM +0200, Bernhard Reutner-Fischer wrote:
>>> A max-repo-count less than or equal to 0 now disables repository
>>> pagination.
>>> Previously a value of 0 or smaller went into an infinite loop just
>>> printing pagination links without any repo.
>> This feels a bit fragile, in that ever use of the max_repo_count
>> variable needs to check this explicitly.  Would it be better to simply
>> set the value to MAX_INT if the config file has a value <= 0?
> Conceptually it feels wrong to use a (high) number to turn something off.

That's why i made 0 disable it, yes.

I'm open to other ideas to disable pagination. I just want to be able
to turn it off somehow..


More information about the CGit mailing list