[PATCH 2/2] css: consistent use of empty lines

Christian Hesse list at eworm.de
Wed Jun 29 10:48:35 CEST 2016


John Keeping <john at keeping.me.uk> on Wed, 2016/06/29 09:34:
> On Wed, Jun 29, 2016 at 09:37:58AM +0200, Christian Hesse wrote:
> > From: Christian Hesse <mail at eworm.de>
> > 
> > Signed-off-by: Christian Hesse <mail at eworm.de>
> > ---
> >  cgit.css | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/cgit.css b/cgit.css
> > index 983eac5..763a99e 100644
> > --- a/cgit.css
> > +++ b/cgit.css  
> [snip obviously correct changes]
> > @@ -824,3 +830,4 @@ div#cgit table.ssdiff td.space {
> >  div#cgit table.ssdiff td.space div {
> >  	min-height: 3em;
> >  }
> > +  
> 
> Is this adding a new line to the end of the file?

Yes, it is.

> I don't think we want
> to do that (doesn't Git warn about it as a whitespace error?).

I tend to add a blank line at the end of my files. That makes sure I still
have a blank line when appending a new block.

Did not see any warnings from git... It did happily commit my changes.

But feel free to drop that change. ;)
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20160629/46a8ef2a/attachment.asc>


More information about the CGit mailing list