[PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links"

[John Keeping]

On Wed, May 11, 2016 at 06:04:15PM +0000, Juuso Lapinlampi wrote:
> vcs-git is not a registered keyword. This microformat does not seem to
> be very popular and will throw errors in HTML validators.
> 
> Because the <link> element leaves us with no sensible rel attribute to
> use, there's no reason to keep this.
> 
> For future consideration, microdata should be marked with Schema.org
> markup instead.
> 
> This reverts commit d31be4ccc2f978edd2a40c2721e1efdc1eee2343.

I'm negative on this, since we had a request to add support [1] and I
generally treat validator errors like compiler warnings: some of them
aren't very useful and should be disabled.

Also the whatwg HTML spec [2] says:

	Extensions to the predefined set of link types may be registered
	in the microformats wiki existing-rel-values page. [MFREL]

Now, admittedly, vcs-git isn't registered there but I'm also not
convinced HTML validators will be checking there, and the spec goes on
to say:

	Anyone is free to edit the microformats wiki existing-rel-values
	page at any time to add a type.

So I'm not convinced that this really is non-conformant.

[1] https://lists.zx2c4.com/pipermail/cgit/2014-August/002191.html
[2] https://html.spec.whatwg.org/multipage/semantics.html#other-link-types

> ---
>  ui-summary.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/ui-summary.c b/ui-summary.c
> index 8e81ac4..375bd45 100644
> --- a/ui-summary.c
> +++ b/ui-summary.c
> @@ -31,11 +31,9 @@ static void print_url(const char *url)
>  		htmlf("<tr class='nohover'><th class='left' colspan='%d'>Clone</th></tr>\n", columns);
>  	}
>  
> -	htmlf("<tr><td colspan='%d'><a rel='vcs-git' href='", columns);
> +	htmlf("<tr><td colspan='%d'><a href='", columns);
>  	html_url_path(url);
> -	html("' title='");
> -	html_attr(ctx.repo->name);
> -	html(" Git repository'>");
> +	html("'>");
>  	html_txt(url);
>  	html("</a></td></tr>\n");
>  }
> -- 
> 2.8.1
> 
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit