[PATCH 5/5] ui-shared: Remove a name attribute with an empty value
John Keeping
john at keeping.me.uk
Wed May 11 20:52:20 CEST 2016
On Wed, May 11, 2016 at 06:04:18PM +0000, Juuso Lapinlampi wrote:
> The name attribute is optional in an input element, but it must not be
> an empty value.
>
> See: https://html.spec.whatwg.org/#attr-fe-name
> See: https://html.spec.whatwg.org/#the-input-element
Again, sign-off is needed, but otherwise:
Reviewed-by: John Keeping <john at keeping.me.uk>
> ---
> ui-shared.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 0b7fdec..a0dec5e 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -947,7 +947,7 @@ static void print_header(void)
> if (ctx.repo->enable_remote_branches)
> for_each_remote_ref(print_branch_option, ctx.qry.head);
> html("</select> ");
> - html("<input type='submit' name='' value='switch'/>");
> + html("<input type='submit' value='switch'/>");
> html("</form>");
> }
> } else
> --
> 2.8.1
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
More information about the CGit
mailing list