[PATCH v5 1/1] ui-shared: allow to split the repository link

Jason A. Donenfeld Jason at zx2c4.com
Wed Nov 23 05:15:54 CET 2016


Hi Petr,

Sorry this has taken so long to review properly. Comments inline below:

On Thu, May 12, 2016 at 5:44 PM, Petr Vorel <petr.vorel at gmail.com> wrote:
> This behaviour is not implemented for repositories which have
> "repo.name" set different than "repo.url".

That's annoying. Why? Is there a way to make the behavior consistant?
Is gitweb inconsistent like this too?

>
> This feature is controlled by a new config variable:
> "split-summary-repo-link" (disabled by default).

I realize that John asked for a config variable in v3. But I do wonder
if this really is so necessary. In what case would somebody _not_ want
this behavior?

> +split-summary-repo-link::
> +       Flag which, when set to "1", will make cgit split the repository link in
> +       the top of repository "summary" view. This emulates the same behaviour as
> +       it's in gitweb. This behaviour is not implemented for repositories which
> +       have "repo.name" set different than "repo.url". Default value: "0".

Grammatical errors. No need to mention gitweb.


More information about the CGit mailing list