[PATCH v5 1/1] ui-shared: allow to split the repository link
john at keeping.me.uk
Thu Nov 24 20:14:00 CET 2016
On Thu, Nov 24, 2016 at 06:42:32PM +0100, Jason A. Donenfeld wrote:
> On Thu, Nov 24, 2016 at 6:32 PM, Petr Vorel <petr.vorel at gmail.com> wrote:
> > Any idea how to cope with it? I thought to use this feature only if repo.name and repo.url
> > are the same.
> One way might be to always use the `name` part and not the `url`, but
> to ensure that any clickable links are actually useful. Namely, ensure
> that any clickable links go to subtrees that contain other
> repositories. This would also help collapse single-child directories,
> like what we now do in tree view.
> @John - any opinions on this?
I originally suggested using this only when repo.name and repo.url are
the same and I still can't think of a good behaviour for when they
I guess if there is a common path prefix between repo.name and repo.url
then we could implement this behaviour for that, but that feels like
we're getting too far into edge cases.
Basically, this feels like a good initial implementation that punts the
complexity for us to deal with when/if someone has a use case. It also
has the advantage of being easy to explain in documentation.
> >> I realize that John asked for a config variable in v3. But I do wonder
> >> if this really is so necessary. In what case would somebody _not_ want
> >> this behavior?
> > I don't think so, I'd also remove the config variable.
> I'll defer to John, then, to defend having a config variable.
It looks like my original argument was essentially "some people might
object to the change in behaviour", so I have no problem with just
changing it and adding a config variable later if people scream.
More information about the CGit