Small patch makes cgit crash

Christian Hesse list at eworm.de
Fri Oct 7 13:17:19 CEST 2016


Christian Hesse <list at eworm.de> on Fri, 2016/10/07 11:51:
> Christian Hesse <list at eworm.de> on Fri, 2016/10/07 11:33:
> > Sylvain Rabot <sylvain at abstraction.fr> on Fri, 2016/10/07 11:27:  
> > > I've made a small patch to make cgit's summary layout look more like
> > > gitweb's. It works but in some cases which I wasn't able to determine
> > > the particulars it seems to crash and the clone url and the footer are
> > > not displayed, e.g. :    
> > 
> > Does it crash with the patch applied only?  
> 
> Ok, I can reproduce. For any reason info->subject is NULL when passed to
> cgit_commit_link() in print_branch() (ui-refs.c, line 70).

The issue is calling free_commit_buffer() in cgit_print_log() (ui-log.c, line
509). That frees data we need later...
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20161007/113a8848/attachment.asc>


More information about the CGit mailing list