[PATCH 1/1] ui-log: fix data corruption

Christian Hesse list at eworm.de
Fri Oct 7 23:25:55 CEST 2016


Christian Hesse <list at eworm.de> on Fri, 2016/10/07 23:21:
> "Jason A. Donenfeld" <Jason at zx2c4.com> on Fri, 2016/10/07 21:43:
> > Does this ever get freed, though?  
> 
> I ran cgit in valgrind with this patch applied. No changes in what is lost -
> so looks like this is freed later on.

Another thought on this... The issue reported by Sylvain Rabot
shows that get_revision() can not get the same commit again. This is an
indication we do free something we should not touch, no?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20161007/559985fa/attachment-0001.asc>


More information about the CGit mailing list