[PATCH] cache: flush stdio before restoring FDs

Konstantin Ryabitsev mricon at kernel.org
Fri Apr 28 18:36:51 CEST 2017

On Mon, Apr 24, 2017 at 2:57 PM John Keeping <john at keeping.me.uk> wrote:

> As described in commit 2efb59e (ui-patch: Flush stdout after outputting
> data, 2014-06-11), we need to ensure that stdout is flushed before
> restoring the file descriptor when writing to the cache.  It turns out
> that it's not just ui-patch that is affected by this but also raw diff
> which writes to stdout internally.
> Let's avoid risking more places doing this by ensuring that stdout is
> flushed after writing in fill_slot().

Thanks, John, this is working and fixes the truncation bug for both patches
and rawdiffs.

Konstantin Ryabitsev
Director, IT Infrastructure Security
The Linux Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170428/2d549480/attachment.html>

More information about the CGit mailing list