[PATCH 2/3] parsing: clear query path before starting

John Keeping john at keeping.me.uk
Sun Feb 19 13:45:00 CET 2017

By specifying the "url" query parameter multiple times it is possible to
end up with ctx.qry.vpath set while ctx.repo is null, which triggers an
invalid code path from cgit_print_pageheader() while printing path
crumbs, resulting in a null dereference.

The previous patch fixed this segfault, but it makes no sense for us to
clear ctx.repo while leaving ctx.qry.path set to the previous value, so
let's just clear it here so that the last "url" parameter given takes
full effect rather than partially overriding the effect of the previous

Signed-off-by: John Keeping <john at keeping.me.uk>
 parsing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parsing.c b/parsing.c
index 9dacb16..b8d7f10 100644
--- a/parsing.c
+++ b/parsing.c
@@ -21,6 +21,7 @@ void cgit_parse_url(const char *url)
 	struct cgit_repo *repo;
 	ctx.repo = NULL;
+	ctx.qry.page = NULL;
 	if (!url || url[0] == '\0')
@@ -53,7 +54,6 @@ void cgit_parse_url(const char *url)
 		if (cmd[1])
 			ctx.qry.page = xstrdup(cmd + 1);
-		return;

More information about the CGit mailing list