[RFCv2 PATCH 0/7] Add ui-blame

Jeffrey Smith whydoubt at gmail.com
Sun Sep 24 05:05:55 CEST 2017

I will start re-arranging the patches to follow your suggestion.

On Sat, Sep 23, 2017 at 10:53 AM, John Keeping <john at keeping.me.uk> wrote:
> On Fri, Sep 22, 2017 at 10:38:41PM -0500, Jeff Smith wrote:
>> I split git blame functionality into libgit, and the changes were
>> accepted upstream and are a part of git 2.14.  Now that the git
>> infrastructure is in place, here is what is needed for cgit to make use
>> of it.
>> Jeff Smith (7):
>>   ui-blame: create enable-blame config item
>>   ui-blame: create framework
>>   ui-blame: create links
>>   ui-blame: html_ntxt with no ellipsis
>>   ui-blame: pull blame info from libgit
>>   ui-blame: begin building
>>   ui-blame: generate blame page when requested
> I still find the arrangement of this patch series a bit strange, I think
> it should be more like:
> - html: html_ntxt with no ellipsis
> - ui-tree: move set_title_from_path to ui-shared
> - ui-blame: add blame UI
>         A squashed version of your "begin building" and "pull blame info
>         from libgit"; splitting them up just makes it harder to review
>         I think it also makes sense to squash the config, cmd and
>         Makefile changes into this patch so that the feature springs
>         into life fully formed, and then the following patches just link
>         it into place
> - ui-tree: link to blame UI if enabled

More information about the CGit mailing list