[PATCH 3/5] ui-shared: make a char* parameter const

John Keeping john at keeping.me.uk
Sat Sep 30 14:00:17 CEST 2017


On Wed, Sep 27, 2017 at 05:43:29PM -0500, Jeff Smith wrote:
> All cgit_xxx_link functions take const char* for the 'name' parameter,
> except for cgit_commit_link, which takes a char* and subsequently
> modifies the contents.  Avoiding the content changes, and making it
> const char* will avoid the need to make copies of const char* strings
> being passed to cgit_commit_link.
> 
> Signed-off-by: Jeff Smith <whydoubt at gmail.com>

Reviewed-by: John Keeping <john at keeping.me.uk>

> ---
>  ui-shared.c | 19 ++++++++-----------
>  ui-shared.h |  2 +-
>  2 files changed, 9 insertions(+), 12 deletions(-)


More information about the CGit mailing list