[PATCH 0/5] Add ui-blame

John Keeping john at keeping.me.uk
Sat Sep 30 14:10:36 CEST 2017


On Wed, Sep 27, 2017 at 05:43:26PM -0500, Jeff Smith wrote:
> I split git blame functionality into libgit, and the changes were
> accepted upstream and are a part of git 2.14.  Now that the git
> infrastructure is in place, here is what is needed for cgit to make use
> of it.
> 
> Since RFCv2:
> . Re-ordered and squashed some of the patches
> . Used cgit's commitinfo structure
> . Factored set_title_from_path out to ui-shared
> . Made cgit_commit_link's first parameter const char*
> . Disabled the feature by default
> . Simplified changes to html_ntxt / html_txt
> 
> Jeff Smith (5):
>   html: html_ntxt with no ellipsis
>   ui-tree: move set_title_from_path to ui-shared
>   ui-shared: make a char* parameter const
>   ui-blame: add blame UI
>   ui-tree: link to blame UI if enabled

This looks pretty good now.  I've sent some comments on a couple of
patches, but the only one I think is important is using (s)size_t for
html_nxt in patch 1.


More information about the CGit mailing list