[PATCH 1/9] parsing: ban strncpy()
Christian Hesse
list at eworm.de
Tue Aug 28 20:38:18 CEST 2018
From: Christian Hesse <mail at eworm.de>
Git upstream bans strncpy() with commit:
banned.h: mark strncpy() as banned
e488b7aba743d23b830d239dcc33d9ca0745a9ad
Signed-off-by: Christian Hesse <mail at eworm.de>
---
parsing.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/parsing.c b/parsing.c
index 12453c2..e224564 100644
--- a/parsing.c
+++ b/parsing.c
@@ -63,8 +63,7 @@ static char *substr(const char *head, const char *tail)
if (tail < head)
return xstrdup("");
buf = xmalloc(tail - head + 1);
- strncpy(buf, head, tail - head);
- buf[tail - head] = '\0';
+ strlcpy(buf, head, tail - head + 1);
return buf;
}
More information about the CGit
mailing list