[PATCH 7/9] ui-ssdiff: ban strncpy()
Christian Hesse
list at eworm.de
Tue Aug 28 20:38:24 CEST 2018
From: Christian Hesse <mail at eworm.de>
Git upstream bans strncpy() with commit:
banned.h: mark strncpy() as banned
e488b7aba743d23b830d239dcc33d9ca0745a9ad
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-ssdiff.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 68c2044..a3dd059 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -103,8 +103,7 @@ static int line_from_hunk(char *line, char type)
return 0;
len = buf2 - buf1;
buf2 = xmalloc(len + 1);
- strncpy(buf2, buf1, len);
- buf2[len] = '\0';
+ strlcpy(buf2, buf1, len + 1);
res = atoi(buf2);
free(buf2);
return res;
More information about the CGit
mailing list