[PATCH v2 2/2] snapshot: support tar signature for compressed tar

Christian Hesse list at eworm.de
Thu Jun 7 21:36:45 CEST 2018

John Keeping <john at keeping.me.uk> on Thu, 2018/06/07 16:21:
> I was thinking we could just to the lookup here, so walk the array to
> find the base signature type.  That avoids the dependency on the order
> of the table.

Did that, works perfectly. I will reply with patch v3.

> What I'd really like to do is avoid storing the "bit" field in the array
> and just calculate it from the index, something like:
> 	1u << (fmt - &cgit_snapshot_formats[0])
> but I haven't followed all of the consumers of the snapshots array to
> figure out if it's easy to convert them.

Let's have a look at that later, currently I do not need it.
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180607/c10b1702/attachment.asc>

More information about the CGit mailing list