[PATCH v2 06/15] ui-tree: split out buffer printing
Andy Green
andy at warmcat.com
Mon Jun 18 04:57:45 CEST 2018
From: John Keeping <john at keeping.me.uk>
Signed-off-by: John Keeping <john at keeping.me.uk>
---
ui-tree.c | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/ui-tree.c b/ui-tree.c
index e6b3074..d26e35e 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -84,6 +84,20 @@ static void print_binary_buffer(char *buf, unsigned long size)
html("</table>\n");
}
+static void print_buffer(const char *basename, char *buf, unsigned long size)
+{
+ if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
+ htmlf("<div class='error'>blob size (%ldKB) exceeds display size limit (%dKB).</div>",
+ size / 1024, ctx.cfg.max_blob_size);
+ return;
+ }
+
+ if (buffer_is_binary(buf, size))
+ print_binary_buffer(buf, size);
+ else
+ print_text_buffer(basename, buf, size);
+}
+
static void print_object(const struct object_id *oid, char *path, const char *basename, const char *rev)
{
enum object_type type;
@@ -117,16 +131,7 @@ static void print_object(const struct object_id *oid, char *path, const char *ba
}
html(")\n");
- if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
- htmlf("<div class='error'>blob size (%ldKB) exceeds display size limit (%dKB).</div>",
- size / 1024, ctx.cfg.max_blob_size);
- return;
- }
-
- if (buffer_is_binary(buf, size))
- print_binary_buffer(buf, size);
- else
- print_text_buffer(basename, buf, size);
+ print_buffer(basename, buf, size);
free(buf);
}
More information about the CGit
mailing list