[PATCH v4 11/16] md2html: add asset mapping
john at keeping.me.uk
Wed Jun 27 22:00:14 CEST 2018
On Wed, Jun 27, 2018 at 07:32:56PM +0200, Jason A. Donenfeld wrote:
> On Wed, Jun 20, 2018 at 12:13 PM Andy Green <andy at warmcat.com> wrote:
> > md2html <README.md README.md /path/to/plain/directory/
> > The trailing "/" is important.
> Can we make it not important? That is, if the type is always
> explicitly a directory, treat it as such using the usual file name
> joining logic.
Seems sensible. This was originally posted as a proof of concept, so
would benefit from a bit of tidying.
I'm not actually sure if it does the right think when cfg.virtual_root
is NULL so we may need something a bit more complicated than this (and I
can't see a way that doesn't require the filter to handle both types of
> Alternatively, and perhaps better, don't introduce a second argument.
> Just pass the full file path in the first argument, and have asset
> mapping always work it out in the right way.
It depends how we think about the first argument. The URL of the
"current page" when we call the filter will be something like:
but the asset path should point to:
We could just say it's the URL of the input file, which is actually
quite nice if we want the filter to be able to replace the content with
However, I think there's a big benefit in backwards compatibility if we
keep the first argument as a file name and don't change it to a URL.
But that doesn't stop us making the new argument into a URL to the file.
More information about the CGit