[PATCH v4 16/16] md2html: change css name to not conflict with highlight

Andy Green andy at warmcat.com
Wed Jun 27 23:58:42 CEST 2018



On 06/28/2018 01:37 AM, Jason A. Donenfeld wrote:
> Hi Andy,
> 
> This seems like an obvious thing to merge, but I'm actually not so
> certain I understand its necessity. md2html uses the highlight class.
> Our css uses the highlight class. You're saying this conflicts with
> something? From where? Third-party CSS? If that's the case, and if

I'm saying blame renders wrongly on Fedora 28 for these reasons and the 
patch fixes it.

> it's a serious problem to recon with, do we then want to just
> namespace all of our classes as .cgit subclasses, or as
> .cgit-highlight, .cgit-whatever prefixes?

I dunno what you want to do about it, but I wanted it to render 
correctly on Fedora 28, which this patch is enough to do.

-Andy



More information about the CGit mailing list