[PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI

Jason A. Donenfeld Jason at zx2c4.com
Thu Jun 28 01:30:33 CEST 2018


On Thu, Jun 28, 2018 at 1:24 AM Andy Green <andy at warmcat.com> wrote:
> Can you help me understand what is "clearly superior" and "right way"
> about the [...] menu in github?
>
> Since you seem to be asking me to implement it?
>
> What put me off it was there's only one useful option on it, and it
> requires and extra click.

I think we should have all three of github's options -- copying the
range, copying a permalink to it, and a simple link to git blame. If
you think that's too arduous and only really care about copying, then
instead of [...] in the menu you can just put 📋 (or whatever other
glyph) as a small icon inside the range, as opposed to a large
slow-fading side link. Though, I still think the menu is better than
📋, because with 📋 it's still unclear what precisely is being copied.

Jason


More information about the CGit mailing list