[RFC/PATCH 1/7] ui-refs: remove unnecessary sanity check

John Keeping john at keeping.me.uk
Sat Mar 31 17:35:48 CEST 2018


There is no way for refinfo::refname to be null, and Git will prevent
zero-length refs so this check is unnecessary.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
 ui-refs.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ui-refs.c b/ui-refs.c
index 50d9d30..7b95e8b 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -97,9 +97,6 @@ static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
 	struct strbuf filename = STRBUF_INIT;
 	size_t prefixlen;
 
-	if (!ref || strlen(ref) < 1)
-		return;
-
 	basename = cgit_snapshot_prefix(repo);
 	if (starts_with(ref, basename))
 		strbuf_addstr(&filename, ref);
-- 
2.16.3



More information about the CGit mailing list