[RFC] remove "diff" link at top bar?

Eric Wong e at 80x24.org
Wed Apr 3 03:14:40 CEST 2019

I've been running this for a few months, now, but forgot to send
it out for review.  Perhaps I'm missing something obvious, but
I've never understood the purpose exposing the "diff" endpoint
at the top navigation bar...

The following applies on top of my:
"ui-shared: improve pageheader display on text-based browsers"
patch which hasn't gotten any feedback, yet.

Subject: [PATCH] ui-shared: get rid of "diff" link at top bar

It's pointless clutter, since the "commit" link shows
the same information.
 ui-shared.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ui-shared.c b/ui-shared.c
index a859ab0..1bb22e6 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -1054,9 +1054,6 @@ void cgit_print_pageheader(void)
 		html(" ");
 		cgit_commit_link("commit", NULL, hc("commit"),
 				 ctx.qry.head, ctx.qry.sha1, ctx.qry.vpath);
-		html(" ");
-		cgit_diff_link("diff", NULL, hc("diff"), ctx.qry.head,
-			       ctx.qry.sha1, ctx.qry.sha2, ctx.qry.vpath);
 		if (ctx.repo->max_stats) {
 			html(" ");
 			cgit_stats_link("stats", NULL, hc("stats"),

More information about the CGit mailing list