[PATCH 1/2] ui-blame: bail if blob is binary
C. McEnroe
june at causal.agency
Wed Dec 18 22:52:30 CET 2019
This avoids piping binary blobs through the source-filter.
---
ui-blame.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui-blame.c b/ui-blame.c
index 644c30a..ecbe325 100644
--- a/ui-blame.c
+++ b/ui-blame.c
@@ -151,6 +151,10 @@ static void print_object(const struct object_id *oid, const char *path,
cgit_tree_link("tree", NULL, NULL, ctx.qry.head, rev, path);
html(")\n");
+ if (buffer_is_binary(buf, size)) {
+ html("<div class='error'>blob is binary.</div>");
+ goto cleanup;
+ }
if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
htmlf("<div class='error'>blob size (%ldKB)"
" exceeds display size limit (%dKB).</div>",
--
2.23.0
More information about the CGit
mailing list