[PATCH 0/5] SVG diffstat graphs and HTML5

Chris Mayo aklhfex at gmail.com
Mon Feb 18 21:46:39 CET 2019

diffstat graphs were not displaying correctly for me because their use of
inline style was being blocked by my content security policy. So I rewrote
them in SVG, which also saves a nested table and a padding element.

As part of checking this I ran the W3C Markup Validator, which reported
several HTML errors and warnings. Hence the rest of the patches here which
fix a number of errors and warnings, but not all e.g. ssdiff still causes
errors for reusing id's.

For the deprecated table summary attribute, not sure what the intent of this
was, I replaced with aria-label, if it was for accessibility.
Maybe "data-summary" instead?

Chris Mayo (5):
  ui-diff: use SVG for diffstat graphs
  Replace table summary attribute with aria-label
  Replace self-closing syntax on non-void elements
  ui-log,ui-refs: ensure there are cells for each column
  ui-shared: add encoding declaration

 cgit.css              | 16 +++++-----------
 tests/t0105-commit.sh |  2 +-
 ui-commit.c           |  2 +-
 ui-diff.c             | 26 +++++++++++++-------------
 ui-log.c              |  6 +++++-
 ui-refs.c             |  2 +-
 ui-repolist.c         |  2 +-
 ui-shared.c           |  1 +
 ui-stats.c            |  4 ++--
 ui-summary.c          |  2 +-
 ui-tree.c             |  8 ++++----
 11 files changed, 35 insertions(+), 36 deletions(-)


More information about the CGit mailing list