[PATCH 1/2] ui-snapshot: add support for zstd compression

Christian Hesse list at eworm.de
Wed Feb 26 23:38:11 CET 2020


Unit 193 <unit193 at ubuntu.com> on Wed, 2020/02/26 17:21:
> > Wow, thanks for doing this. I had just been discussing this with
> > Unit193, who submitted a similar but not as complete patch a few days
> > ago to me on IRC.  
> 
> Indeed!  Thanks for looking into this!

I just implemented this after the lzip patch was merged... Did not even know
you discussed this. :-p

> > We had been discussing which compression level to pass to zstd or to
> > leave it as default. I think Unit193 had some thoughts on that, so
> > CC'ing him in case he wants to jump in.  
> 
> Yes.  My initial version did bump the compression level as well, but in the
> end I decided against that in order to give the user the option to control
> that via ZSTD_CLEVEL.

Good idea... So we could go with `xz -T0` to enable multi-threading (as this
can not be controlled via environment variable).
Then we document in man page how to influence compression level via
environment variable.

We have to set the environment variable from web server, no?

Do we also want to document GZIP, XZ_DEFAULTS & friends?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20200226/dbd549dd/attachment.asc>


More information about the CGit mailing list