Weird interactions betwen cache and module-link

John Keeping john at keeping.me.uk
Sat Mar 26 10:30:41 UTC 2022


On Fri, Mar 25, 2022 at 09:44:48PM +0000, Gianni Ceccarelli wrote:
> This patch seems to fix the problem.

Nice catch!  This definitely looks like an oversight.

Would you like to type up a proper patch with a commit message and
Signed-off-by certification?  We use the same process as git.git so
their SubmittingPatches document [1] explains this.

[1] https://git-scm.com/docs/SubmittingPatches#sign-off

> diff --git c/cgit.c w/cgit.c
> index 08d81a1..d30e259 100644
> --- c/cgit.c
> +++ w/cgit.c
> @@ -810,6 +810,10 @@ static void print_repo(FILE *f, struct cgit_repo *repo)
>  		fprintf(f, "repo.extra-head-content=%s\n", repo->extra_head_content);
>  	if (repo->module_link)
>  		fprintf(f, "repo.module-link=%s\n", repo->module_link);
> +	for (int i = 0; i < repo->submodules.nr; ++i) {
> +		struct string_list_item *si=&repo->submodules.items[i];
> +		fprintf(f, "repo.module-link.%s=%s\n", si->string, (char*)si->util);
> +	}
>  	if (repo->section)
>  		fprintf(f, "repo.section=%s\n", repo->section);
>  	if (repo->homepage)
> 
> 
> -- 
> 	Dakkar - <Mobilis in mobile>
> 	GPG public key fingerprint = A071 E618 DD2C 5901 9574
> 	                             6FE2 40EA 9883 7519 3F88
> 	                    key id = 0x75193F88
> 


More information about the CGit mailing list