Follow-up: User-configurable log graph option

[Kian Kasad]

Hello cgit developers,

Just over a year ago, I proposed a configurable "graph" option for the
log page. The idea was met with positive feedback, but when I proposed
my implementation I never heard back. So I'm trying again in hopes that
I can get a response. It would be nice if this was merged into the
upstream so I don't have to maintain my fork, but if the way I've
chosen to go about it isn't desirable, then I understand. But even in
the latter case, I need a "no" so I know to stop trying to push this.

The original conversation is below. I've also finished the
implementation and am using it at https://git.kasad.com if you'd like
to test it out.

See here for my fork of cgit implementing this change:
https://git.kasad.com/cgit/log/?h=feat%2Fgraph-page

On Thu, 2021-12-30 at 13:08 -0800, Kian Kasad wrote:
> On 21/02/19 12:22PM, John Keeping wrote:
> > On Thu, Feb 18, 2021 at 02:31:26PM -0800, Kian Kasad wrote:
> > > I'm using cgit on my website and I'm wondering if it's possible
> > > to allow
> > > the user (i.e. the person visiting the site) to choose whether or
> > > not
> > > the commit graph is displayed on the log page.
> > > 
> > > If this isn't currently possible, what do you think about adding
> > > such
> > > functionality? Maybe something like how the diff page lets the
> > > user
> > > choose between a "unified diff" and "ssdiff".
> > 
> > This sounds like a great new feature!
> > 
> > I think we still want to allow the administrator to turn the
> > feature
> > on/off but if it is permitted, then it makes sense to allow the end
> > user
> > to choose whether or not they want it enabled.
> 
> Following up on this as I'm finally getting around to implementing
> this
> feature. I'm not too familiar with CGit's codebase, so I think it
> would
> be easier to implement this as a separate "graph" page which is
> identical to the log page except that it always displays a graph.
> 
> This graph page would only be shown in the navbar's tab list if the
> "enable-commit-graph" option is set to "separate" in the
> configuration.
> If it is set to "combined" then the graph page will be disabled and
> the
> commit graph will be displayed on the log page as it currently is
> when
> the "enable-commit-graph" option is set to "1".
> 
> In order to maintain backwards compatibility, the value "1" could
> also
> be interpreted as the value "combined" since it has the same
> functionality currently.
> 
> The value "none" (or "0" for backwards compatibility) would disable
> the
> graph page as well as disabling the commit graph on the log page.
> 
> I've already started working on this as I want it for my own CGit
> site.
> If this is something that the maintainer(s) want to integrate, I'll
> send
> patches when I'm done.

-- 
Kian Kasad
PGP 0x1715EEAA14DAEC1
kian at kasad.com
(925) 871-9823