[PATCH 1/1] RFC: git: update to v2.41.0-rc2

Jason A. Donenfeld Jason at zx2c4.com
Fri May 26 14:18:42 UTC 2023


On Fri, May 26, 2023 at 4:17 PM Christian Hesse <list at eworm.de> wrote:
>
> Christian Hesse <list at eworm.de> on Fri, 2023/05/26 16:06:
> > > Like string_list_split(), except that string is split in-place: the
> > > delimiter characters in string are overwritten with NULs, and the
> > > new string_list_items point into string (which therefore must not
> > > be modified or freed while the string_list is in use).
> > > list->strdup_strings must *not* be set.
> >
> > So we should be fine with the change, no?
>
> Ah, the strings are not allocated, but we should run:
>
> string_list_clear(&list, 0);
>
> Is it fine then?

Right. My understanding is that while the strings themselves are not
allocated, the array of string list items still is.


More information about the CGit mailing list