From list at eworm.de  Wed Apr 10 13:25:16 2024
From: list at eworm.de (Christian Hesse)
Date: Wed, 10 Apr 2024 15:25:16 +0200
Subject: More detailed log URLs?
In-Reply-To: <CZQAS8NJZXG4.GRQ2ITD0FVXC@cepl.eu>
References: <CZQAS8NJZXG4.GRQ2ITD0FVXC@cepl.eu>
Message-ID: <20240410152516.76f5e75d@leda.eworm.net>

Mat?j Cepl <mcepl at cepl.eu> on Sun, 2024/03/10 19:56:
> Hi,
> 
> is it possible to have cgit show log from one commit to
> another? Something like the equivalent of gitweb's
> http://localhost:4321/cgi-bin/gitweb.cgi?p=.git;a=shortlog;h=update-lexers;hp=master

Something like this?

https://git.zx2c4.com/cgit/patch/?id=00ecfaadea2c40cc62b7a43e246384329e6ddb98&id2=093ac9697068833a15cae2dbbd5ffbc0203741c0
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240410/c2657f99/attachment.sig>

From list at eworm.de  Wed Apr 10 13:29:38 2024
From: list at eworm.de (Christian Hesse)
Date: Wed, 10 Apr 2024 15:29:38 +0200
Subject: Enhancement request : ui-blob: Make the target line of a link,
 visually identifiable.
In-Reply-To: <5e2ed4ad-256b-40cf-bf40-68bf67336b8c@free.fr>
References: <5e2ed4ad-256b-40cf-bf40-68bf67336b8c@free.fr>
Message-ID: <20240410152938.1a3f53e3@leda.eworm.net>

Lo?c <lagiraudiere+cgit at free.fr> on Sat, 2024/02/03 18:20:
> Hi all,
> 
> When I create a reference to a precise line in a file (for instance a 
> hyperlink to "https://git.zx2c4.com/cgit/tree/cgit.css#n321" ), I miss a 
> visual feedback, on the line I want to highlight.
> 
> To implement this feature, I suggest to add a curved arrow ahead of the 
> line number.
> That could be done by adding the following stylesheet to cgit.css
> 
>  ?? div#cgit table.blob td.linenumbers a:target:before {color: 
> red;content: "\2BA9";}

I really like that functionality, though the curved arrow is really
inconspicuous. Wondering if something like "large red circle" (or "large
black circle", colored in red) would be a better match...
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240410/f35f6b9d/attachment.sig>

From list at eworm.de  Wed Apr 10 13:31:41 2024
From: list at eworm.de (Christian Hesse)
Date: Wed, 10 Apr 2024 15:31:41 +0200
Subject: [PATCH 1/1] git: update to v2.44.0
In-Reply-To: <20240223173103.200567-1-list@eworm.de>
References: <20240223173103.200567-1-list@eworm.de>
Message-ID: <20240410153141.3c642ecf@leda.eworm.net>

Christian Hesse <list at eworm.de> on Fri, 2024/02/23 18:31:
> From: Christian Hesse <mail at eworm.de>
> 
> Update to git version v2.44.0, no additional changes required.
> 
> Signed-off-by: Christian Hesse <mail at eworm.de>

And just another ping, any chance for fast-forwarded into master?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240410/fb64dad5/attachment.sig>

From lagiraudiere+cgit at free.fr  Sun Apr 14 21:56:48 2024
From: lagiraudiere+cgit at free.fr (=?UTF-8?B?TG/Dr2M=?=)
Date: Sun, 14 Apr 2024 23:56:48 +0200
Subject: Enhancement request : ui-blob: Make the target line of a link,
 visually identifiable.
In-Reply-To: <20240410152938.1a3f53e3@leda.eworm.net>
References: <5e2ed4ad-256b-40cf-bf40-68bf67336b8c@free.fr>
 <20240410152938.1a3f53e3@leda.eworm.net>
Message-ID: <9fa56309-2907-4d01-a811-f438189dee8d@free.fr>

Le 10/04/2024 ? 15:29, Christian Hesse a ?crit?:
> Lo?c <lagiraudiere+cgit at free.fr> on Sat, 2024/02/03 18:20:
>> Hi all,
>>
>> When I create a reference to a precise line in a file (for instance a
>> hyperlink to "https://git.zx2c4.com/cgit/tree/cgit.css#n321" ), I miss a
>> visual feedback, on the line I want to highlight.
>>
>> To implement this feature, I suggest to add a curved arrow ahead of the
>> line number.
>> That could be done by adding the following stylesheet to cgit.css
>>
>>   ?? div#cgit table.blob td.linenumbers a:target:before {color:
>> red;content: "\2BA9";}
> I really like that functionality, though the curved arrow is really
> inconspicuous. Wondering if something like "large red circle" (or "large
> black circle", colored in red) would be a better match...

Unfortunately, the size is constrained by the underlying font.

Initially, I searched for a character like "BLACK RIGHT POINTING 
BACKHAND INDEX" or "LINK SYMBOL", but it was even smaller. I also tried 
to change the font size but it didn't produce a good result either since 
it changes the line height.

So, feel free to change the mark to something more convenient. The 
"large black circle" (\2B24), colored in red seems fine. (I prefer the 
"BLACK LARGE CIRCLE" colored in red over the "LARGE RED CIRCLE" because 
it makes it easier to change the color)


From list at eworm.de  Mon Apr 15 08:45:35 2024
From: list at eworm.de (Christian Hesse)
Date: Mon, 15 Apr 2024 10:45:35 +0200
Subject: Enhancement request : ui-blob: Make the target line of a link,
 visually identifiable.
In-Reply-To: <9fa56309-2907-4d01-a811-f438189dee8d@free.fr>
References: <5e2ed4ad-256b-40cf-bf40-68bf67336b8c@free.fr>
 <20240410152938.1a3f53e3@leda.eworm.net>
 <9fa56309-2907-4d01-a811-f438189dee8d@free.fr>
Message-ID: <20240415104535.3d985290@leda.eworm.net>

Lo?c <lagiraudiere+cgit at free.fr> on Sun, 2024/04/14 23:56:
> Le 10/04/2024 ? 15:29, Christian Hesse a ?crit?:
> > Lo?c <lagiraudiere+cgit at free.fr> on Sat, 2024/02/03 18:20:  
> >> Hi all,
> >>
> >> When I create a reference to a precise line in a file (for instance a
> >> hyperlink to "https://git.zx2c4.com/cgit/tree/cgit.css#n321" ), I miss a
> >> visual feedback, on the line I want to highlight.
> >>
> >> To implement this feature, I suggest to add a curved arrow ahead of the
> >> line number.
> >> That could be done by adding the following stylesheet to cgit.css
> >>
> >>   ?? div#cgit table.blob td.linenumbers a:target:before {color:
> >> red;content: "\2BA9";}  
> > I really like that functionality, though the curved arrow is really
> > inconspicuous. Wondering if something like "large red circle" (or "large
> > black circle", colored in red) would be a better match...  
> 
> Unfortunately, the size is constrained by the underlying font.

Ah sure... Experience may differ depending on font.

> Initially, I searched for a character like "BLACK RIGHT POINTING 
> BACKHAND INDEX" or "LINK SYMBOL", but it was even smaller. I also tried 
> to change the font size but it didn't produce a good result either since 
> it changes the line height.
> 
> So, feel free to change the mark to something more convenient. The 
> "large black circle" (\2B24), colored in red seems fine. (I prefer the 
> "BLACK LARGE CIRCLE" colored in red over the "LARGE RED CIRCLE" because 
> it makes it easier to change the color)

After all Jason has to decide...
Let's hope we will see any activity soon.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240415/77b71d8f/attachment.sig>

From mcepl at cepl.eu  Mon Apr 15 20:07:14 2024
From: mcepl at cepl.eu (=?utf-8?q?Mat=C4=9Bj_Cepl?=)
Date: Mon, 15 Apr 2024 22:07:14 +0200
Subject: More detailed log URLs?
In-Reply-To: <20240410152516.76f5e75d@leda.eworm.net>
References: <CZQAS8NJZXG4.GRQ2ITD0FVXC@cepl.eu>
 <20240410152516.76f5e75d@leda.eworm.net>
Message-ID: <D0KYU7X352HZ.2XSC7TRRS5OZO@cepl.eu>

On Wed Apr 10, 2024 at 3:25 PM CEST, Christian Hesse wrote:
> Mat?j Cepl <mcepl at cepl.eu> on Sun, 2024/03/10 19:56:
> > Hi,
> > 
> > is it possible to have cgit show log from one commit to
> > another? Something like the equivalent of gitweb's
> > http://localhost:4321/cgi-bin/gitweb.cgi?p=.git;a=shortlog;h=update-lexers;hp=master
>
> Something like this?
>
> https://git.zx2c4.com/cgit/patch/?id=00ecfaadea2c&id2=093ac9697068

Right, https://git.cepl.eu/cgit/git/git-bz/patch/?id=apply_on_cascade&id2=git-bz-python3_adaptation
works, but it is far from convenient.

1. I don?t see any documentation for it anywhere.
2. id and id2 are far from intutive. Could we get something like
   top and base instead?
3. Error handling is insufficient. When you switch those
   parameters (again, no documentation) the reply is just a blank
   page.

I can help with documentation, but not much with changes in the C
code.

Best,

Mat?j

-- 
http://matej.ceplovi.cz/blog/, @mcepl at floss.social
GPG Finger: 3C76 A027 CA45 AD70 98B5  BC1D 7920 5802 880B C9D8
 
My life has been full of terrible misfortunes most of which never
happened.
    -- Martin Farquhar Tupper (mistakenly attributed to Michel de
       Montaigne by Dale Carnegie,
       https://quoteinvestigator.com/?p=7370)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: E09FEF25D96484AC.asc
Type: application/pgp-keys
Size: 3102 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240415/42d8d14d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 216 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240415/42d8d14d/attachment.sig>

From list at eworm.de  Fri Apr 19 20:47:41 2024
From: list at eworm.de (Christian Hesse)
Date: Fri, 19 Apr 2024 22:47:41 +0200
Subject: [PATCH 1/1] RFC: git: update to v2.45.0-rc0
Message-ID: <20240419204741.41191-1-list@eworm.de>

From: Christian Hesse <mail at eworm.de>

Update to git version v2.45.0-rc0, this requires changes for these
upstream commits:

* 9720d23e8caf4adee44b3a32803a9bb0480118bd
  date: make DATE_MODE thread-safe

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 Makefile    | 4 ++--
 git         | 2 +-
 ui-shared.c | 4 ++--
 ui-shared.h | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index c3ee267..d3bcc0b 100644
--- a/Makefile
+++ b/Makefile
@@ -14,8 +14,8 @@ htmldir = $(docdir)
 pdfdir = $(docdir)
 mandir = $(prefix)/share/man
 SHA1_HEADER = <openssl/sha.h>
-GIT_VER = 2.44.0
-GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz
+GIT_VER = 2.45.0.rc0
+GIT_URL = https://www.kernel.org/pub/software/scm/git/testing/git-$(GIT_VER).tar.xz
 INSTALL = install
 COPYTREE = cp -r
 MAN5_TXT = $(wildcard *.5.txt)
diff --git a/git b/git
index 3c2a3fd..ae3196a 160000
--- a/git
+++ b/git
@@ -1 +1 @@
-Subproject commit 3c2a3fdc388747b9eaf4a4a4f2035c1c9ddb26d0
+Subproject commit ae3196a5ea84a9e88991d576020cf66512487088
diff --git a/ui-shared.c b/ui-shared.c
index eef2aa8..d5b5b20 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -662,12 +662,12 @@ void cgit_submodule_link(const char *class, char *path, const char *rev)
 		path[len - 1] = tail;
 }
 
-const struct date_mode *cgit_date_mode(enum date_mode_type type)
+const struct date_mode cgit_date_mode(enum date_mode_type type)
 {
 	static struct date_mode mode;
 	mode.type = type;
 	mode.local = ctx.cfg.local_time;
-	return &mode;
+	return mode;
 }
 
 static void print_rel_date(time_t t, int tz, double value,
diff --git a/ui-shared.h b/ui-shared.h
index 6964873..f12fa99 100644
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -65,7 +65,7 @@ __attribute__((format (printf,1,2)))
 extern void cgit_print_error(const char *fmt, ...);
 __attribute__((format (printf,1,0)))
 extern void cgit_vprint_error(const char *fmt, va_list ap);
-extern const struct date_mode *cgit_date_mode(enum date_mode_type type);
+extern const struct date_mode cgit_date_mode(enum date_mode_type type);
 extern void cgit_print_age(time_t t, int tz, time_t max_relative);
 extern void cgit_print_http_headers(void);
 extern void cgit_redirect(const char *url, bool permanent);
-- 
2.44.0


From list at eworm.de  Wed Apr 24 20:36:38 2024
From: list at eworm.de (Christian Hesse)
Date: Wed, 24 Apr 2024 22:36:38 +0200
Subject: [PATCH 1/1] RFC: git: update to v2.45.0-rc1
In-Reply-To: <20240419204741.41191-1-list@eworm.de>
References: <20240419204741.41191-1-list@eworm.de>
Message-ID: <20240424203638.48083-1-list@eworm.de>

From: Christian Hesse <mail at eworm.de>

Update to git version v2.45.0-rc1, this requires changes for these
upstream commits:

* 9720d23e8caf4adee44b3a32803a9bb0480118bd
  date: make DATE_MODE thread-safe

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 Makefile    | 4 ++--
 git         | 2 +-
 ui-shared.c | 4 ++--
 ui-shared.h | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index c3ee267..0654f70 100644
--- a/Makefile
+++ b/Makefile
@@ -14,8 +14,8 @@ htmldir = $(docdir)
 pdfdir = $(docdir)
 mandir = $(prefix)/share/man
 SHA1_HEADER = <openssl/sha.h>
-GIT_VER = 2.44.0
-GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz
+GIT_VER = 2.45.0.rc1
+GIT_URL = https://www.kernel.org/pub/software/scm/git/testing/git-$(GIT_VER).tar.xz
 INSTALL = install
 COPYTREE = cp -r
 MAN5_TXT = $(wildcard *.5.txt)
diff --git a/git b/git
index 3c2a3fd..bf995e7 160000
--- a/git
+++ b/git
@@ -1 +1 @@
-Subproject commit 3c2a3fdc388747b9eaf4a4a4f2035c1c9ddb26d0
+Subproject commit bf995e7a4f94a9388aa8042dc9e338f3fcb75496
diff --git a/ui-shared.c b/ui-shared.c
index eef2aa8..d5b5b20 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -662,12 +662,12 @@ void cgit_submodule_link(const char *class, char *path, const char *rev)
 		path[len - 1] = tail;
 }
 
-const struct date_mode *cgit_date_mode(enum date_mode_type type)
+const struct date_mode cgit_date_mode(enum date_mode_type type)
 {
 	static struct date_mode mode;
 	mode.type = type;
 	mode.local = ctx.cfg.local_time;
-	return &mode;
+	return mode;
 }
 
 static void print_rel_date(time_t t, int tz, double value,
diff --git a/ui-shared.h b/ui-shared.h
index 6964873..f12fa99 100644
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -65,7 +65,7 @@ __attribute__((format (printf,1,2)))
 extern void cgit_print_error(const char *fmt, ...);
 __attribute__((format (printf,1,0)))
 extern void cgit_vprint_error(const char *fmt, va_list ap);
-extern const struct date_mode *cgit_date_mode(enum date_mode_type type);
+extern const struct date_mode cgit_date_mode(enum date_mode_type type);
 extern void cgit_print_age(time_t t, int tz, time_t max_relative);
 extern void cgit_print_http_headers(void);
 extern void cgit_redirect(const char *url, bool permanent);
-- 
2.44.0


From fossdd at pwned.life  Mon Apr 29 09:21:14 2024
From: fossdd at pwned.life (fossdd)
Date: Mon, 29 Apr 2024 09:21:14 +0000
Subject: New releases of cgit
Message-ID: <D0WHV84B95PR.3C1VL2QYP1PUC@pwned.life>

Hello,

is there a reason why no release has been made in the last 4 years,
while the master is still getting new commits?

Otherwise it would be nice if a tag could be made so that distributions
can pick them up.

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20240429/44d63d09/attachment.sig>

From list at eworm.de  Mon Apr 29 19:15:10 2024
From: list at eworm.de (Christian Hesse)
Date: Mon, 29 Apr 2024 21:15:10 +0200
Subject: [PATCH 1/1] git: update to v2.45.0
Message-ID: <20240429191510.14574-1-list@eworm.de>

From: Christian Hesse <mail at eworm.de>

Update to git version v2.45.0, this requires changes for these
upstream commits:

* 9720d23e8caf4adee44b3a32803a9bb0480118bd
  date: make DATE_MODE thread-safe

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 Makefile    | 2 +-
 git         | 2 +-
 ui-shared.c | 4 ++--
 ui-shared.h | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index c3ee267..2612a75 100644
--- a/Makefile
+++ b/Makefile
@@ -14,7 +14,7 @@ htmldir = $(docdir)
 pdfdir = $(docdir)
 mandir = $(prefix)/share/man
 SHA1_HEADER = <openssl/sha.h>
-GIT_VER = 2.44.0
+GIT_VER = 2.45.0
 GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz
 INSTALL = install
 COPYTREE = cp -r
diff --git a/git b/git
index 3c2a3fd..786a3e4 160000
--- a/git
+++ b/git
@@ -1 +1 @@
-Subproject commit 3c2a3fdc388747b9eaf4a4a4f2035c1c9ddb26d0
+Subproject commit 786a3e4b8d754d2b14b1208b98eeb0a554ef19a8
diff --git a/ui-shared.c b/ui-shared.c
index eef2aa8..d5b5b20 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -662,12 +662,12 @@ void cgit_submodule_link(const char *class, char *path, const char *rev)
 		path[len - 1] = tail;
 }
 
-const struct date_mode *cgit_date_mode(enum date_mode_type type)
+const struct date_mode cgit_date_mode(enum date_mode_type type)
 {
 	static struct date_mode mode;
 	mode.type = type;
 	mode.local = ctx.cfg.local_time;
-	return &mode;
+	return mode;
 }
 
 static void print_rel_date(time_t t, int tz, double value,
diff --git a/ui-shared.h b/ui-shared.h
index 6964873..f12fa99 100644
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -65,7 +65,7 @@ __attribute__((format (printf,1,2)))
 extern void cgit_print_error(const char *fmt, ...);
 __attribute__((format (printf,1,0)))
 extern void cgit_vprint_error(const char *fmt, va_list ap);
-extern const struct date_mode *cgit_date_mode(enum date_mode_type type);
+extern const struct date_mode cgit_date_mode(enum date_mode_type type);
 extern void cgit_print_age(time_t t, int tz, time_t max_relative);
 extern void cgit_print_http_headers(void);
 extern void cgit_redirect(const char *url, bool permanent);
-- 
2.44.0