From sadeep at asciimx.com Sun Oct 5 11:50:11 2025 From: sadeep at asciimx.com (Sadeep Madurange) Date: Sun, 5 Oct 2025 19:50:11 +0800 Subject: Can't get the favicon to work on OpenBSD Message-ID: Dear list, I installed cgit on an OpenBSD server. Everything went well except for the favicon. I placed my favicon in /var/www/cgit (chroot) directory with the following permissions: -rw-r--r-- 1 www daemon 408142 Oct 5 11:16 favicon.ico In cgitrc, I have 'favicon=/favicon.ico'. However, the request in the browser to get the favicon is failing with 404 error. -- Sadeep W. Don PGP: 103BF9E3E750BF7E From lists at alfredbuehler.ch Sun Oct 5 12:57:08 2025 From: lists at alfredbuehler.ch (=?UTF-8?Q?Alfred_B=C3=BChler?=) Date: Sun, 5 Oct 2025 14:57:08 +0200 Subject: Can't get the favicon to work on OpenBSD In-Reply-To: References: Message-ID: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> On 2025-10-05 13:50, Sadeep Madurange wrote: > -rw-r--r-- 1 www daemon 408142 Oct 5 11:16 favicon.ico Maybe a 400k favicon might be too large? From sadeep at asciimx.com Sun Oct 5 13:18:10 2025 From: sadeep at asciimx.com (Sadeep Madurange) Date: Sun, 5 Oct 2025 21:18:10 +0800 Subject: Can't get the favicon to work on OpenBSD In-Reply-To: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> References: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> Message-ID: On 2025-10-05 14:57:08, Alfred B?hler wrote: > On 2025-10-05 13:50, Sadeep Madurange wrote: > > -rw-r--r-- 1 www daemon 408142 Oct 5 11:16 favicon.ico > Maybe a 400k favicon might be too large? Tried with a 16x16 one. That didn't work either: -rw-r--r-- 1 www daemon 1150 Oct 5 13:13 favicon.ico -- Sadeep W. Don PGP: 103BF9E3E750BF7E From lists at alfredbuehler.ch Sun Oct 5 14:09:43 2025 From: lists at alfredbuehler.ch (=?UTF-8?Q?Alfred_B=C3=BChler?=) Date: Sun, 5 Oct 2025 16:09:43 +0200 Subject: Can't get the favicon to work on OpenBSD In-Reply-To: References: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> Message-ID: <3ca9ceba-58ee-494b-b2cc-f076bbd2d2b3@alfredbuehler.ch> May I assume you tried without that favicon spec in cgitrc? Here it works out of the box. From sadeep at asciimx.com Sun Oct 5 14:49:03 2025 From: sadeep at asciimx.com (Sadeep Madurange) Date: Sun, 5 Oct 2025 22:49:03 +0800 Subject: Can't get the favicon to work on OpenBSD In-Reply-To: <3ca9ceba-58ee-494b-b2cc-f076bbd2d2b3@alfredbuehler.ch> References: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> <3ca9ceba-58ee-494b-b2cc-f076bbd2d2b3@alfredbuehler.ch> Message-ID: On 2025-10-05 16:09:43, Alfred B?hler wrote: > May I assume you tried without that favicon spec in cgitrc? > Here it works out of the box. Yes, I tried commenting out the favicon setting to no avail. My complete cgitrc file now is: cache-size=1000 clone-url=git at git.asciimx.com:/repos/$CGIT_REPO_URL footer=/conf/cgit.footer css=/cgit.css enable-index-owner=0 enable-http-clone=0 enable-index-links=0 enable-commit-graph=1 enable-log-filecount=1 enable-log-linecount=1 branch-sort=age # favicon=/favicon.ico max-stats=quarter root-title=ASCIIMX Repositories root-desc=My description snapshots=tar.gz mimetype.gif=image/gif mimetype.html=text/html mimetype.jpg=image/jpeg mimetype.jpeg=image/jpeg mimetype.pdf=application/pdf mimetype.png=image/png mimetype.svg=image/svg+xml readme=:README virtual-root=/ scan-path=/htdocs/src repo.snapshots=0 repo.enable-log-linecount=0 repo.max-stats=month -- Sadeep W. Don PGP: 103BF9E3E750BF7E From sadeep at asciimx.com Wed Oct 8 13:46:17 2025 From: sadeep at asciimx.com (W. D. Sadeep) Date: Wed, 8 Oct 2025 21:46:17 +0800 Subject: Can't get the favicon to work on OpenBSD In-Reply-To: References: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> <3ca9ceba-58ee-494b-b2cc-f076bbd2d2b3@alfredbuehler.ch> Message-ID: On 2025-10-05 22:49:07, Sadeep Madurange wrote: > On 2025-10-05 16:09:43, Alfred B?hler wrote: > > May I assume you tried without that favicon spec in cgitrc? > > Here it works out of the box. > > Yes, I tried commenting out the favicon setting to no avail. Turned out this was a misconfiguration in my web server config. I'd forgotten to add the following to serve the favicon. location "/favicon.ico" { root "/cgit" no fastcgi } Sorry for the noise. -- W. D. Sadeep PGP: 103BF9E3E750BF7E From lists at alfredbuehler.ch Thu Oct 9 11:51:21 2025 From: lists at alfredbuehler.ch (=?UTF-8?Q?Alfred_B=C3=BChler?=) Date: Thu, 9 Oct 2025 13:51:21 +0200 Subject: Can't get the favicon to work on OpenBSD In-Reply-To: References: <1f4524c4-0f89-4dda-940e-f3ca84138a1d@alfredbuehler.ch> <3ca9ceba-58ee-494b-b2cc-f076bbd2d2b3@alfredbuehler.ch> Message-ID: <49fb3c2d-d4f9-4f10-952f-81ef1cf00446@alfredbuehler.ch> On 2025-10-08 15:46, W. D. Sadeep wrote: > Sorry for the noise. No problem, thanks for posting your solution. From rob at robdavies.net Mon Oct 13 09:20:46 2025 From: rob at robdavies.net (rob at robdavies.net) Date: Mon, 13 Oct 2025 10:20:46 +0100 Subject: can I build cgit statically Message-ID: Hi Is there a way to build cgit statically? I'm trying to build cgit with lua on a shared web hosting. I have built lua libraries and need to static link these lua libraries, this is due to having no way to add lua libraries to LD_LIBRARY_PATH to run cgit Kind regards, Rob From list at eworm.de Thu Oct 16 07:53:00 2025 From: list at eworm.de (Christian Hesse) Date: Thu, 16 Oct 2025 09:53:00 +0200 Subject: [PATCH 1/1] git: update to v2.51.1 Message-ID: <20251016075301.54046-1-list@eworm.de> From: Christian Hesse Update to git version v2.51.1, this requires changes for these upstream commits: * e1d062e8ba0b72f49e9ef9713cc7011c330baab8 odb: drop deprecated wrapper functions Signed-off-by: Christian Hesse --- Makefile | 2 +- git | 2 +- parsing.c | 2 +- shared.c | 2 +- ui-blame.c | 4 ++-- ui-blob.c | 14 +++++++------- ui-plain.c | 4 ++-- ui-snapshot.c | 2 +- ui-tree.c | 8 ++++---- 9 files changed, 20 insertions(+), 20 deletions(-) diff --git a/Makefile b/Makefile index 60075af..b54f297 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,7 @@ htmldir = $(docdir) pdfdir = $(docdir) mandir = $(prefix)/share/man SHA1_HEADER = -GIT_VER = 2.51.0 +GIT_VER = 2.51.1 GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz INSTALL = install COPYTREE = cp -r diff --git a/git b/git index c44beea..81f86aa 160000 --- a/git +++ b/git @@ -1 +1 @@ -Subproject commit c44beea485f0f2feaf460e2ac87fdd5608d63cf0 +Subproject commit 81f86aacc4eb74cdb9c2c8082d36d2070c666045 diff --git a/parsing.c b/parsing.c index 5616d43..115ce81 100644 --- a/parsing.c +++ b/parsing.c @@ -200,7 +200,7 @@ struct taginfo *cgit_parse_tag(struct tag *tag) const char *p; struct taginfo *ret = NULL; - data = repo_read_object_file(the_repository, &tag->object.oid, &type, &size); + data = odb_read_object(the_repository->objects, &tag->object.oid, &type, &size); if (!data || type != OBJ_TAG) goto cleanup; diff --git a/shared.c b/shared.c index c1403b4..3838364 100644 --- a/shared.c +++ b/shared.c @@ -243,7 +243,7 @@ static int load_mmfile(mmfile_t *file, const struct object_id *oid) file->ptr = (char *)""; file->size = 0; } else { - file->ptr = repo_read_object_file(the_repository, oid, &type, + file->ptr = odb_read_object(the_repository->objects, oid, &type, (unsigned long *)&file->size); } return 1; diff --git a/ui-blame.c b/ui-blame.c index d07b67f..9c575ef 100644 --- a/ui-blame.c +++ b/ui-blame.c @@ -121,14 +121,14 @@ static void print_object(const struct object_id *oid, const char *path, struct blame_origin *o; struct blame_entry *ent = NULL; - type = oid_object_info(the_repository, oid, &size); + type = odb_read_object_info(the_repository->objects, oid, &size); if (type == OBJ_BAD) { cgit_print_error_page(404, "Not found", "Bad object name: %s", oid_to_hex(oid)); return; } - buf = repo_read_object_file(the_repository, oid, &type, &size); + buf = odb_read_object(the_repository->objects, oid, &type, &size); if (!buf) { cgit_print_error_page(500, "Internal server error", "Error reading object %s", oid_to_hex(oid)); diff --git a/ui-blob.c b/ui-blob.c index e554fe9..bc91656 100644 --- a/ui-blob.c +++ b/ui-blob.c @@ -56,7 +56,7 @@ int cgit_ref_path_exists(const char *path, const char *ref, int file_only) if (repo_get_oid(the_repository, ref, &oid)) goto done; - if (oid_object_info(the_repository, &oid, &size) != OBJ_COMMIT) + if (odb_read_object_info(the_repository->objects, &oid, &size) != OBJ_COMMIT) goto done; read_tree(the_repository, repo_get_commit_tree(the_repository, lookup_commit_reference(the_repository, &oid)), @@ -91,18 +91,18 @@ int cgit_print_file(char *path, const char *head, int file_only) if (repo_get_oid(the_repository, head, &oid)) return -1; - type = oid_object_info(the_repository, &oid, &size); + type = odb_read_object_info(the_repository->objects, &oid, &size); if (type == OBJ_COMMIT) { commit = lookup_commit_reference(the_repository, &oid); read_tree(the_repository, repo_get_commit_tree(the_repository, commit), &paths, walk_tree, &walk_tree_ctx); if (!walk_tree_ctx.found_path) return -1; - type = oid_object_info(the_repository, &oid, &size); + type = odb_read_object_info(the_repository->objects, &oid, &size); } if (type == OBJ_BAD) return -1; - buf = repo_read_object_file(the_repository, &oid, &type, &size); + buf = odb_read_object(the_repository->objects, &oid, &type, &size); if (!buf) return -1; buf[size] = '\0'; @@ -147,13 +147,13 @@ void cgit_print_blob(const char *hex, char *path, const char *head, int file_onl } } - type = oid_object_info(the_repository, &oid, &size); + type = odb_read_object_info(the_repository->objects, &oid, &size); if ((!hex) && type == OBJ_COMMIT && path) { commit = lookup_commit_reference(the_repository, &oid); read_tree(the_repository, repo_get_commit_tree(the_repository, commit), &paths, walk_tree, &walk_tree_ctx); - type = oid_object_info(the_repository, &oid, &size); + type = odb_read_object_info(the_repository->objects, &oid, &size); } if (type == OBJ_BAD) { @@ -162,7 +162,7 @@ void cgit_print_blob(const char *hex, char *path, const char *head, int file_onl return; } - buf = repo_read_object_file(the_repository, &oid, &type, &size); + buf = odb_read_object(the_repository->objects, &oid, &type, &size); if (!buf) { cgit_print_error_page(500, "Internal server error", "Error reading object %s", hex); diff --git a/ui-plain.c b/ui-plain.c index 4d69607..0301439 100644 --- a/ui-plain.c +++ b/ui-plain.c @@ -24,13 +24,13 @@ static int print_object(const struct object_id *oid, const char *path) char *buf, *mimetype; unsigned long size; - type = oid_object_info(the_repository, oid, &size); + type = odb_read_object_info(the_repository->objects, oid, &size); if (type == OBJ_BAD) { cgit_print_error_page(404, "Not found", "Not found"); return 0; } - buf = repo_read_object_file(the_repository, oid, &type, &size); + buf = odb_read_object(the_repository->objects, oid, &type, &size); if (!buf) { cgit_print_error_page(404, "Not found", "Not found"); return 0; diff --git a/ui-snapshot.c b/ui-snapshot.c index 3e38cd5..d157222 100644 --- a/ui-snapshot.c +++ b/ui-snapshot.c @@ -192,7 +192,7 @@ static int write_sig(const struct cgit_snapshot_format *format, return 0; } - buf = repo_read_object_file(the_repository, note, &type, &size); + buf = odb_read_object(the_repository->objects, note, &type, &size); if (!buf) { cgit_print_error_page(404, "Not found", "Not found"); return 0; diff --git a/ui-tree.c b/ui-tree.c index 3d8a2eb..5ac8c9a 100644 --- a/ui-tree.c +++ b/ui-tree.c @@ -93,14 +93,14 @@ static void print_object(const struct object_id *oid, const char *path, const ch unsigned long size; bool is_binary; - type = oid_object_info(the_repository, oid, &size); + type = odb_read_object_info(the_repository->objects, oid, &size); if (type == OBJ_BAD) { cgit_print_error_page(404, "Not found", "Bad object name: %s", oid_to_hex(oid)); return; } - buf = repo_read_object_file(the_repository, oid, &type, &size); + buf = odb_read_object(the_repository->objects, oid, &type, &size); if (!buf) { cgit_print_error_page(500, "Internal server error", "Error reading object %s", oid_to_hex(oid)); @@ -217,7 +217,7 @@ static int ls_item(const struct object_id *oid, struct strbuf *base, ctx.qry.path ? "/" : "", name); if (!S_ISGITLINK(mode)) { - type = oid_object_info(the_repository, oid, &size); + type = odb_read_object_info(the_repository->objects, oid, &size); if (type == OBJ_BAD) { htmlf("Bad object: %s %s", name, @@ -244,7 +244,7 @@ static int ls_item(const struct object_id *oid, struct strbuf *base, } if (S_ISLNK(mode)) { html(" -> "); - buf = repo_read_object_file(the_repository, oid, &type, &size); + buf = odb_read_object(the_repository->objects, oid, &type, &size); if (!buf) { htmlf("Error reading object: %s", oid_to_hex(oid)); goto cleanup; From list at eworm.de Mon Oct 27 16:02:28 2025 From: list at eworm.de (Christian Hesse) Date: Mon, 27 Oct 2025 17:02:28 +0100 Subject: [PATCH 1/1] git: update to v2.51.2 Message-ID: <20251027160228.321373-1-list@eworm.de> From: Christian Hesse Update to git version v2.51.2, no additional changes required. Signed-off-by: Christian Hesse --- Makefile | 2 +- git | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index b54f297..08b4c90 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,7 @@ htmldir = $(docdir) pdfdir = $(docdir) mandir = $(prefix)/share/man SHA1_HEADER = -GIT_VER = 2.51.1 +GIT_VER = 2.51.2 GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz INSTALL = install COPYTREE = cp -r diff --git a/git b/git index 81f86aa..bb5c624 160000 --- a/git +++ b/git @@ -1 +1 @@ -Subproject commit 81f86aacc4eb74cdb9c2c8082d36d2070c666045 +Subproject commit bb5c624209fcaebd60b9572b2cc8c61086e39b57