[pass] [PATCH 1/2] check for pwgen's existance before using

Brian Mattern rephorm at rephorm.com
Thu Sep 20 18:44:53 CEST 2012


On Thu, 20 Sep 2012, Jason A. Donenfeld wrote:

> On Thu, Sep 20, 2012 at 6:06 PM, Brian Mattern <rephorm at rephorm.com> wrote:
> > Storing an empty password with a burried error message is
> > less-than-desirable behavior. At least check that pwgen succeeded as in
> > the attached patch.
> 
> That's a good idea, okay. To be a bit more generic, I'm testing if
> pass is empty, and if it is, just quitting, relying on the previous
> shell-out to print something to stderr already ("cannot be found bla
> bla").
> 
> http://git.zx2c4.com/password-store/commit/?id=5bc781bd38ea4141e5e3b9110bf28214773cf1a3

I'm ok with that. (Although `pass generate foo 0` will quit without
saying why, but that's a pathological enough case...)

Brian



More information about the Password-Store mailing list