[pass] [PATCH] Beef up bash completion

[Jeffrey Ratcliffe]

On 21 September 2012 22:22, Brian Mattern <rephorm at rephorm.com> wrote:
> I have an entry: 'test/example one'.
>
> $ pass te<tab>
> $ pass test/example one<enter>
> test/example is not in the password store.

You're right. I've added a line to escape the spaces. Patch attached
(against HEAD).

> Spaces need to be quoted by the completion mechanism for this to be
> useful, which is why I was passing through printf. Here, although the
> printf expansion of utf8 is ugly, it appears to be functional.
>
> E.g. with an entry: 'utf8â Ž':
>
> $pass utf<tab>
> $pass $'utf8\342\217\216'<enter>

I'm sorry - but this is not functional - unless you know what the UTF8
codes are, you have no clue what that means, and so if your filenames
have more than a trivial amount of UTF8 (think Russian, Chinese, etc.)
then you are hopelessly lost.

With the attached patch (against HEAD), UTF8 is properly displayed.

Regards

Jeff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bash-completion-Fix-UTF8-escape-spaces-clean-up.patch
Type: application/octet-stream
Size: 2006 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20120922/19988922/attachment.obj>