[pass] [PATCH] fix bash completion install bug (see c832d46)

Alex Burka durka42 at gmail.com
Sun Oct 27 04:16:39 CET 2013

Hi everyone,

I'm new to the mailing list (and to pass). I brought light refreshments and two one-line patches (first one is below). I'm also interested in working on Android! Not sure if I can reply to that thread since it started before I was here.

This patch makes pass install cleanly from git with Homebrew on OSX.

A previous commit (c832d46) fixed the installation of the bash completions to be less invasive, but then seems to have left behind a bug in the Makefile because it creates a directory, then tries to install the bash completions to a different directory (which doesn't exist, due to Homebrew sandboxing everything).


 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index d134f26..ea37404 100644
--- a/Makefile
+++ b/Makefile
@@ -12,7 +12,7 @@ all:
    @echo "Password store is a shell script, so there is nothing to do. Try \"make install\" instead."

-   @mkdir -p "$(DESTDIR)$(BINDIR)" "$(DESTDIR)$(LIBDIR)" "$(DESTDIR)$(MANDIR)/man1" "$(DESTDIR)$(SYSCONFDIR)/bash_completion.d"
+   @mkdir -p "$(DESTDIR)$(BINDIR)" "$(DESTDIR)$(LIBDIR)" "$(DESTDIR)$(MANDIR)/man1" "$(DESTDIR)$(PREFIX)/share/bash-completion/completions"
    @install -m 0755 -v src/password-store.sh "$(DESTDIR)$(BINDIR)/pass"
    @install -m 0644 -v man/pass.1 "$(DESTDIR)$(MANDIR)/man1/pass.1"
    @install -m 0644 -v contrib/pass.bash-completion "$(DESTDIR)$(PREFIX)/share/bash-completion/completions/password-store"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20131026/8ec4e85f/attachment.html>

More information about the Password-Store mailing list