[pass] 'pass insert' bugs

[Von Welch]

>
> On Sun, Apr 20, 2014 at 8:18 PM, Von Welch <von at vwelch.com> wrote:
> 1) "echo foo | pass insert my-pass" fails, but still creates an empty
> file. See appended example 1.
>
> http://git.zx2c4.com/password-store/commit/?id=91ef9dbbea26573414220073dd92bba4b1d4c94a


You fixed the interactive case, but the following now hangs if the password
does not exist:

% echo "foo" | ../src/password-store.sh insert my-pass

(It also points out a shortcoming of sharness.sh, which is it doesn't
support any timeouts on tests that I can see.)

...

> Seems to be the desired behavior, since you don't have to enter the
> password twice in -e mode, right?


I suggest that returning a non-zero status but not printing an error
message is a bug. If a user isn't explicitly checking the return status
(it's obvious to me because my prompt prints it), they could easily miss
the failure.

Von


On Sun, Apr 20, 2014 at 6:48 PM, Jason A. Donenfeld <Jason at zx2c4.com> wrote:

>
>
> On Sun, Apr 20, 2014 at 8:18 PM, Von Welch <von at vwelch.com> wrote:
>>
>> 1) "echo foo | pass insert my-pass" fails, but still creates an empty
>> file. See appended example 1.
>>
>
>
> http://git.zx2c4.com/password-store/commit/?id=91ef9dbbea26573414220073dd92bba4b1d4c94a
>
>
>>
>> 2) "echo foo | pass -e insert my-pass" returns 1 if my-pass exists but is
>> otherwise silent. See appended example 2.
>>
>
> Seems to be the desired behavior, since you don't have to enter the
> password twice in -e mode, right? You can use -f to override already
> existing passwords with no prompt.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20140420/dd6854b3/attachment.html>