[pass] commit message tense

[Paul Schwendenman]

While I agree that commits should be imperative when you are working on a
project, If I pull in this commit it will do this. However in this case, I
believe git is being used to keep a historical record. I would argue that
historical records should be past tense.

Consistency is also important in my opinion and as you've pointed out some
current messages don't translate to imperative cleanly.

But perhaps I am the only one with this mindset?

Paul


On Wed, Apr 23, 2014 at 12:47 PM, George Angelopoulos <george at usermod.net>wrote:

> Yes, in certain cases, present tense wouldn't make any sense. For example:
>
> "Edit password for foo using vim."
>
> lolwut?
>
> On 04/23/2014 07:43 PM, Paul Schwendenman wrote:
> > I thought because the tool was making the commits it made more sense
> > to have them be past tense.
> >
> > Paul
> >
> >
> > On Wed, Apr 23, 2014 at 12:17 PM, Jason A. Donenfeld <Jason at zx2c4.com
> > <mailto:Jason at zx2c4.com>> wrote:
> >
> >     Good point. I guess I just have a different hat on when writing
> >     code (to make commits) versus actually making commits. I agree
> >     present tense makes more sense. Send a patch cleaning that up, and
> >     I'll merge it?
> >
> >     _______________________________________________
> >     Password-Store mailing list
> >     Password-Store at lists.zx2c4.com <mailto:
> Password-Store at lists.zx2c4.com>
> >     http://lists.zx2c4.com/mailman/listinfo/password-store
> >
> >
>
> _______________________________________________
> Password-Store mailing list
> Password-Store at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/password-store
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20140423/92318084/attachment-0001.html>