[pass] [PATCH] use preferred directory for fish completions

David Adam zanchey at ucc.gu.uwa.edu.au
Thu Dec 4 14:23:03 CET 2014


It's great that pass ships with completions for fish. Recently, there's 
been a request[1] that they get included directly into fish, but I think 
it's best that they are maintained and installed as part of pass.

In order to avoid conflicts between completions shipped with fish and 
third-party completions, with the next release of fish[2] we will be 
recommending that all completions get installed into 
`DATADIR/share/fish/vendor_completions.d`. The attached patch changes the 
Makefile to do so.

The most preferable option would be to try calling `pkg-config 
--variable=completionsdir fish` and using the output of that, but there's 
no guarantee that pkg-config exists on all platforms, and stuffing the 
output of a shell command into a Make variable is difficult to get working 
across BSD & GNU Make, so I've left that for now.


David Adam
fish committer
zanchey at ucc.gu.uwa.edu.au

[1]: https://github.com/fish-shell/fish-shell/pull/1843
[2]: https://github.com/fish-shell/fish-shell/issues/1485
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fish-install-completions-in-preferred-directory.patch
Type: text/x-diff
Size: 883 bytes
Desc: 0001-fish-install-completions-in-preferred-directory.patch
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20141204/24a88d3c/attachment.patch>

More information about the Password-Store mailing list