[pass] Bugfix for Mac's diskutil mount point issue

Allan Odgaard lists+pass at simplit.com
Mon Jun 30 14:13:17 CEST 2014


On 30 Jun 2014, at 11:58, Jason A. Donenfeld wrote:

> Are the mountpoints successfully unmounted? (That was the bug, after 
> all...)

Yes, they are removed after use :)

The name of the RAM disk itself is also as expected on OS X (no X’es 
in the name) but the actual file being edited still has them, since the 
patch didn’t update the other calls to ‘mktemp’. I assume you 
changed only the Mac version since it’s in platform.sh and thus could 
be hardcoded for the BSD version of mktemp.

I would however still recommend using:

     mktemp [-d] "${TMPDIR:-/tmp}/$template"

Even in platform.sh this is preferred as some users may have setup their 
PATH to prefer MacPorts/homebrew and have installed GNU coreutils, which 
include the mktemp where ‘-t’ has another meaning. Alternatively 
platform.sh should use /usr/bin/mktemp to ensure the proper version is 
called.


More information about the Password-Store mailing list