[pass] [PATCH v2] Team pass: enable multiple keys and per directory

[Brian Shore]

On Thu, Mar 20, 2014 at 10:13 AM, Jason A. Donenfeld <Jason at zx2c4.com> wrote:
> On Thu, Mar 20, 2014 at 4:46 AM, Brian Shore <brian at networkredux.com> wrote:
>> What happens if the user copies something else to the clipboard a few
>> seconds before pass blanks it?  Copying something non-sensitive and
>> having that data mysteriously disappear from the clipboard is
>> counter-intuitive and gets in the way.
>>
>> I think checking the clipboard content before blanking is still a good
>> thing to do.  Blanking if it's still the password is fine, but
>> destroying new data is not.
>
> From the beginning, pass has accounted for this. Before restoring the
> clipboard, we check whether it's changed since copying the password.
> If it has changed, we consider the "old contents" to be the "current
> contents". Check out the code. It works.

I know.  Josh was suggesting that pass should always blank the
clipboard (after the delay) and dispense with the base64 stuff (which
is needed for checking the contents).  I was advocating the blanking
behavior but only if the clipboard still holds the password, which
requires keeping the comparison, and I think base64 is an important
part of that code.


-- 
Brian Shore
Senior Systems Engineer, Security Architect
Network Redux, LLC
5200 SW Macadam Ave Ste 450
Portland, Oregon 97239
Desk:  503-274-9905 x503