[pass] [PATCH 2/2] bashcomp: disable the 'filenames' completion option

[Mike Charlton]

I'm not Brian, but if that's the whole patch then what it does is not
decorate the output as if it were a file.  It *is* a file of course, but
the user isn't necessarily treating it as one, so IMHO this patch is a good
idea.

On 11 May 2015 at 20:57, <samuel.lethiec at intelunix.fr> wrote:

>
>
> Hello,
>
> Just for the record, I've been using pass with this patch without any
> (apparent) issue.
>
> But, as you said, Brian will help us here!
>
> Thanks,
>
> Samuel
>
> On 2015-05-11 13:51, Jason A. Donenfeld wrote:
>
> I don't really understand things well enough to evaluate this patch.
> Adding Brian, the original author of the bash completion sriipto this
> thread; perhaps he can shed some light.
>
> On Sun, Mar 1, 2015 at 10:25 PM, <samuel.lethiec at intelunix.fr> wrote:
>
>> (did not include this patch in the previous as I'm not entirely sure it
>> does not come with some surprise)
>>
>> the filenames option was adding trailing slash when we already added one
>>
>> ---
>>  src/completion/pass.bash-completion | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/completion/pass.bash-completion
>> b/src/completion/pass.bash-completion
>> index efd4b70..6f82c8d 100644
>> --- a/src/completion/pass.bash-completion
>> +++ b/src/completion/pass.bash-completion
>> @@ -109,4 +109,4 @@ _pass()
>>         fi
>>  }
>>
>> -complete -o filenames -o nospace -F _pass pass
>> +complete -o nospace -F _pass pass
>> --
>> 2.1.0
>>
>> _______________________________________________
>> Password-Store mailing list
>> Password-Store at lists.zx2c4.com
>> http://lists.zx2c4.com/mailman/listinfo/password-store
>>
>
>
>
>
>
>
>
> _______________________________________________
> Password-Store mailing list
> Password-Store at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/password-store
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20150511/100170ab/attachment.html>