[pass] [Patch] Added option to hide password output

[Michael Clemens]

Hi Christoph,

because I have to use Windows + PuTTY at work and I think the hidden 
password option would be the simplest solution in this case. Or does 
PuTTY support something like a shared clipboard? This would be the best 
solution, of course.

Cheers,
Michael


Am 2015-11-23 09:43, schrieb Christoph:
> Hi,
> 
> On Sat, Nov 21, 2015 at 01:10:32AM +0100, Michael Clemens wrote:
>> Hello,
>> 
>> when using pass via ssh on a remote system, I cannot make use of the
>> clipboard feature. In order to output the password without actually
>> displaying it, I wrote the following patch which prints the password 
>> in red
>> on a red background while still being able to be manually copied to 
>> the
>> clipboard:
> 
> Just out of curiosity:
> why don't you do a
>   ssh remote "pass password" | xlclip
> You would end up with the password in you clipboard and wouldn't have
> to copy it manually.
> 
> Cheers,
>   Christoph
>> 
>> From: Michael Clemens <clemens at fsfe.org>
>> Date: Sat, 21 Nov 2015 00:56:54 +0100
>> Subject: [PATCH] added option -h|--hidden, displays password 
>> unreadable (red
>>  fg color on red bg color) where no clipboard is available
>> 
>> ---
>>  src/password-store.sh | 19 +++++++++++++------
>>  1 file changed, 13 insertions(+), 6 deletions(-)
>> 
>> diff --git a/src/password-store.sh b/src/password-store.sh
>> index d535a74..f4e1cfe 100755
>> --- a/src/password-store.sh
>> +++ b/src/password-store.sh
>> @@ -223,8 +223,8 @@ cmd_usage() {
>>  	        List passwords.
>>  	    $PROGRAM find pass-names...
>>  	    	List passwords that match pass-names.
>> -	    $PROGRAM [show] [--clip,-c] pass-name
>> -	        Show existing password and optionally put it on the 
>> clipboard.
>> +	    $PROGRAM [show] [--clip,-c] [--hidden,-h] pass-name
>> +	        Show existing password and optionally put it on the 
>> clipboard or
>> hide it.
>>  	        If put on the clipboard, it will be cleared in $CLIP_TIME 
>> seconds.
>>  	    $PROGRAM grep search-string
>>  	        Search for password files containing search-string when 
>> decrypted.
>> @@ -294,23 +294,30 @@ cmd_init() {
>>  }
>> 
>>  cmd_show() {
>> -	local opts clip=0
>> -	opts="$($GETOPT -o c -l clip -n "$PROGRAM" -- "$@")"
>> +	local opts clip=0 hidden=0
>> +	opts="$($GETOPT -o ch -l clip,hidden -n "$PROGRAM" -- "$@")"
>>  	local err=$?
>>  	eval set -- "$opts"
>>  	while true; do case $1 in
>>  		-c|--clip) clip=1; shift ;;
>> +		-h|--hidden) hidden=1; shift ;;
>>  		--) shift; break ;;
>>  	esac done
>> 
>> -	[[ $err -ne 0 ]] && die "Usage: $PROGRAM $COMMAND [--clip,-c] 
>> [pass-name]"
>> +	[[ $err -ne 0 ]] && die "Usage: $PROGRAM $COMMAND [--clip,-c]
>> [--hidden,-h] [pass-name]"
>> 
>>  	local path="$1"
>>  	local passfile="$PREFIX/$path.gpg"
>>  	check_sneaky_paths "$path"
>>  	if [[ -f $passfile ]]; then
>>  		if [[ $clip -eq 0 ]]; then
>> -			$GPG -d "${GPG_OPTS[@]}" "$passfile" || exit $?
>> +			if [[ $hidden -eq 0 ]]; then
>> +				$GPG -d "${GPG_OPTS[@]}" "$passfile" || exit $?
>> +                       else
>> +				local pass="$($GPG -d "${GPG_OPTS[@]}" "$passfile" | head -n 1)"
>> +				[[ -n $pass ]] || exit 1
>> +                               echo -e "\e[0;31;41m$pass\e[0m"
>> +                       fi
>>  		else
>>  			local pass="$($GPG -d "${GPG_OPTS[@]}" "$passfile" | head -n 1)"
>>  			[[ -n $pass ]] || exit 1
>> --
>> 2.5.0
>> 
>> Greetings,
>> Michael Clemens
>> _______________________________________________
>> Password-Store mailing list
>> Password-Store at lists.zx2c4.com
>> http://lists.zx2c4.com/mailman/listinfo/password-store
>>