git config --global in tests/setup.sh (+ fix suggestion?)

[Tinu Weber]

Hello

I noticed that running `make test` causes my personal, global git
configuration to change, in particular the following two fields:

    name = Pass Automated Testing Suite
    email = Pass-Automated-Testing-Suite at zx2c4.com

This appears to be due to calls to `git config --global ...` in
tests/setup.sh (lines 41/42); removing the --global flag appears to
solve this (it should use the test repository's local git configuration
instead, given the definition of GIT_DIR just above), and so far all
tests still pass.

Am I right to assume that the --global flag is not needed? To be honest,
I find it even a bit dangerous that `make` modifies things outside the
build directory like this (I only noticed this because I track my git
config with git itself).

Best,
Tinu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20171225/3da86ae5/attachment.asc>