[PATCH] Bash 3.x completion support

Graham Lyons graham at grahamlyons.com
Tue Sep 19 12:37:21 CEST 2017


I've followed your process, Erik, and re-attached the patch to this email.

Let me know if there are any problems.

Thanks Oliver - I'm trying to avoid installing anything extra.

On 8 September 2017 at 18:45, Oliver Albertini <oliver.ruben at gmail.com>
wrote:

> Also, you can upgrade your bash version with a package manager. Then you
> have to add it to /etc/shells before changing to the new bash.
>
> On Sep 8, 2017 10:39, "Graham Lyons" <graham at grahamlyons.com> wrote:
>
>> Aha. I just redirected `git diff master` to a file.
>>
>> I'll try your suggestion. Thank you.
>>
>> On 8 Sep 2017 18:23, "Erik Wenzel" <erik at code.de> wrote:
>>
>>>
>>> > On 8. Sep 2017, at 13:15, Graham Lyons <graham at grahamlyons.com> wrote:
>>> >
>>> > Hello,
>>> >
>>> > I'm using password-store on OSX (latest, 10.12.6) which comes with
>>> Bash version 3.2.57. I get errors when using the completion as the
>>> `compopt` command doesn't exist before Bash 4. Avoiding use of `compopt`
>>> still seems to allow the completion to work (I'm guessing there's something
>>> missing) so I've prepared a patch which tests for its existence first.
>>> >
>>> > I hope this is in the right format - let me know if there are any
>>> problems.
>>> The content of your patch fixes my osx bash3 completion issues. Thanks!
>>> The
>>> patch format isn’t right I think. It didn’t apply for me with `git apply
>>> a.patch` and I pasted the content off from your email into `a.patch`. How do
>>> you created the patch?
>>>
>>> When I create the patch using `git format-patch master --stdout >
>>> ../bash3.patch` I get an email header, a stats section and then the patch
>>> like
>>> yours.
>>>
>>> cheers
>>> _______________________________________________
>>> Password-Store mailing list
>>> Password-Store at lists.zx2c4.com
>>> https://lists.zx2c4.com/mailman/listinfo/password-store
>>>
>>
>> _______________________________________________
>> Password-Store mailing list
>> Password-Store at lists.zx2c4.com
>> https://lists.zx2c4.com/mailman/listinfo/password-store
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20170919/bc4a6d80/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bash3.patch
Type: application/octet-stream
Size: 1361 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20170919/bc4a6d80/attachment.obj>


More information about the Password-Store mailing list