[PATCH] Follow symlinks when adding changes to git

David A. listmail at cox.net
Wed Mar 28 21:58:08 CEST 2018


On Fri, 23 Mar 2018 10:32:41 +0100, Lars Flitter
<password-store at larsflitter.de> wrote:

>+	git -C "$INNER_GIT_DIR" add "$(readlink -f "$1")" || return
>+	[[ -n $(git -C "$INNER_GIT_DIR" status --porcelain "$(readlink -f "$1")") ]] || 

I'm not saying this patch is bad, but my first thought is to be very
careful using readlink and/or realpath.  They're very inconsistently
implemented across platforms.  Even on Linux it's difficult to depend
on them as some distros use the GNU coreutils version and some don't.
OSX uses a BSD flavor that has different flags.



More information about the Password-Store mailing list