[PATCH] Add support for XKCD-style wordlist passwords

Brad Knowles brad at shub-internet.org
Tue Oct 30 06:10:24 CET 2018


On Oct 30, 2018, at 12:00 AM, Adhityaa Chandrasekar <pass at adtac.in> wrote:

> +	if [[ "$wordlist" != "" ]]; then
> +		pass=$(shuf -n 4 "$wordlist" | paste -sd "-" -)
> +	else

While I think the concept is a good one, I don't think we should be depending on the user having "shuf" installed on their machine.  I don't have it on mine, and I've installed a whole boatload of extra stuff that most people don't have.

I'm also not sure about "paste", although I do happen to have a program by that name on my machine.

IMO, you're better off sticking to more standard *nix utilities.

-- 
Brad Knowles <brad at shub-internet.org>

Please forgive any typos.  I'm fighting a failing keyboard on my laptop, in addition to having a broken finger.



More information about the Password-Store mailing list