[PATCH] Unset variables messing with Git use

martin f krafft madduck at madduck.net
Wed Aug 14 00:14:00 CEST 2019


Quoting "Amir Yalon", who wrote on 2019-08-13 at 23:09 Uhr +0300:
>> +unset GIT_DIR GIT_WORK_TREE GIT_NAMESPACE GIT_INDEX_FILE GIT_OBJECT_DIRECTORY
>
>The list might not be comprehensive;

No, it's not, but I did consider the others ones:

>GIT_INDEX_FILE

Included.

>GIT_INDEX_VERSION

I was thinking about it, but to be honest, if you are exporting that 
to your shell where you use pass, I am not sure you can be helped. 
But of course, we can add it.

>GIT_OBJECT_DIRECTORY 

Included.

>GIT_ALTERNATE_OBJECT_DIRECTORIES

This doesn't actually hurt. It's only used as a potential source of 
objects.

>GIT_DIR
>GIT_WORK_TREE 
>GIT_NAMESPACE

Included.

>GIT_CEILING_DIRECTORIES
>GIT_DISCOVERY_ACROSS_FILESYSTEM

I thought about these, but I can't see a way in which this would 
affect password-store.

>GIT_COMMON_DIR 

Yeah, this could actually have an impact.

So I'll send an updated patch with GIT_INDEX_VERSION and 
GIT_COMMON_DIR added.

-- 
@martinkrafft | https://riot.im/app/#/room/#madduck:madduck.net
 
takt ist der auf das benehmen angewandte gute geschmack.
                                              -- nicolas de chamfort
 
spamtraps: madduck.bogus at madduck.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: digital_signature_gpg.asc
Type: application/pgp-signature
Size: 1118 bytes
Desc: Digital GPG signature (see http://martin-krafft.net/gpg/sig-policy/999bbcc4/current)
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190814/fb70e977/attachment.asc>


More information about the Password-Store mailing list